Skip to content

koord-descheduler: fix maxMigratingGlobally arg json tag#2144

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
songtao98:fix_max_migrating_globally
Jul 30, 2024
Merged

koord-descheduler: fix maxMigratingGlobally arg json tag#2144
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
songtao98:fix_max_migrating_globally

Conversation

@songtao98
Copy link
Contributor

Ⅰ. Describe what this PR does

This PR add maxMigratingGlobally json tag to enable configuration of this arg.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: songtao98 <songtao2603060@gmail.com>
@koordinator-bot koordinator-bot bot requested review from FillZpp and eahydra July 30, 2024 08:42
@codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (6d7b92f) to head (3209172).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   67.85%   67.85%   -0.01%     
==========================================
  Files         441      441              
  Lines       41720    41720              
==========================================
- Hits        28309    28308       -1     
  Misses      10971    10971              
- Partials     2440     2441       +1     
Flag Coverage Δ
unittests 67.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Jul 30, 2024

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 880717b into koordinator-sh:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants