Skip to content

koord-descheduler: update k8s descheduler to 0.28.0#2156

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
songtao98:update_k8s_descheduler
Sep 2, 2024
Merged

koord-descheduler: update k8s descheduler to 0.28.0#2156
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
songtao98:update_k8s_descheduler

Conversation

@songtao98
Copy link
Contributor

Ⅰ. Describe what this PR does

Koordinator has update k8s version to 1.28.7 and koord-descheduler was adapted to Kubernetes Descheduler v0.26.0 which relies on k8s version 1.26.0.

This PR updates the k8s descheduler version to 0.28.0. In this version the k8s descheduler relies on k8s version 1.28.0, fixes some bugs and add more args in descheduler plugins.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (65bfe26) to head (34fd068).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
- Coverage   67.88%   67.87%   -0.02%     
==========================================
  Files         443      443              
  Lines       41921    41921              
==========================================
- Hits        28460    28453       -7     
- Misses      11006    11013       +7     
  Partials     2455     2455              
Flag Coverage Δ
unittests 67.87% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: songtao98 <songtao2603060@gmail.com>
@songtao98 songtao98 force-pushed the update_k8s_descheduler branch from 4033ce7 to 34fd068 Compare August 6, 2024 12:46
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2df0762 into koordinator-sh:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants