Skip to content

koord-descheduler: fixes namespace object limiter#2160

Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
songtao98:fix_namespace_object_limiter
Sep 2, 2024
Merged

koord-descheduler: fixes namespace object limiter#2160
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
songtao98:fix_namespace_object_limiter

Conversation

@songtao98
Copy link
Contributor

Ⅰ. Describe what this PR does

Currently, if user uses evictAllBarePods to evict a bare pod, the namespace object limiter cannot get its ownerRef to add a limiterKey for this pod's namespace. This lead to the namespace limiter for bare pods does not work.

This PR fixes namespace object limiter for koord-descheduler's MigrationController.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and eahydra August 6, 2024 13:03
@codecov
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.68%. Comparing base (e15a68c) to head (04ed872).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/descheduler/controllers/migration/util/util.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
- Coverage   67.69%   67.68%   -0.02%     
==========================================
  Files         446      446              
  Lines       42686    42694       +8     
==========================================
- Hits        28898    28896       -2     
- Misses      11269    11277       +8     
- Partials     2519     2521       +2     
Flag Coverage Δ
unittests 67.68% <69.23%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songtao98 songtao98 force-pushed the fix_namespace_object_limiter branch from ca866fe to 9b35f4c Compare August 7, 2024 10:32
@koordinator-bot koordinator-bot bot added size/L and removed size/XS labels Aug 7, 2024
@songtao98 songtao98 force-pushed the fix_namespace_object_limiter branch from 9b35f4c to a07a265 Compare August 7, 2024 11:26
@songtao98 songtao98 force-pushed the fix_namespace_object_limiter branch 2 times, most recently from 0813002 to 0d3d3f5 Compare August 9, 2024 04:27
Signed-off-by: songtao98 <songtao2603060@gmail.com>
@songtao98 songtao98 force-pushed the fix_namespace_object_limiter branch from 0d3d3f5 to 4bf287f Compare August 13, 2024 07:39
@hormes
Copy link
Member

hormes commented Sep 2, 2024

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@koordinator-bot koordinator-bot bot removed the lgtm label Sep 2, 2024
@hormes hormes added the lgtm label Sep 2, 2024
@koordinator-bot koordinator-bot bot merged commit 6074e77 into koordinator-sh:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants