koord-descheduler: fixes namespace object limiter#2160
koord-descheduler: fixes namespace object limiter#2160koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2160 +/- ##
==========================================
- Coverage 67.69% 67.68% -0.02%
==========================================
Files 446 446
Lines 42686 42694 +8
==========================================
- Hits 28898 28896 -2
- Misses 11269 11277 +8
- Partials 2519 2521 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ca866fe to
9b35f4c
Compare
9b35f4c to
a07a265
Compare
0813002 to
0d3d3f5
Compare
Signed-off-by: songtao98 <songtao2603060@gmail.com>
0d3d3f5 to
4bf287f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Ⅰ. Describe what this PR does
Currently, if user uses evictAllBarePods to evict a bare pod, the namespace object limiter cannot get its ownerRef to add a limiterKey for this pod's namespace. This lead to the namespace limiter for bare pods does not work.
This PR fixes namespace object limiter for koord-descheduler's MigrationController.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test