Skip to content

koordlet: add record events#2162

Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
kangclzjc:dev_recorder
Aug 20, 2024
Merged

koordlet: add record events#2162
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
kangclzjc:dev_recorder

Conversation

@kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

Add record events for all the runtime hook

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Describe how to verify it

Add RecorderEvents in protocol, and kubectl describe pod.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@kangclzjc kangclzjc changed the title add record events koordlet: add record events Aug 8, 2024
@kangclzjc
Copy link
Member Author

@saintube PTAL.

@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (7eaa33a) to head (69cf4fa).
Report is 8 commits behind head on main.

Files Patch % Lines
pkg/koordlet/koordlet.go 0.00% 1 Missing ⚠️
...oordlet/runtimehooks/protocol/container_context.go 0.00% 1 Missing ⚠️
...koordlet/runtimehooks/protocol/host_qos_context.go 0.00% 1 Missing ⚠️
.../koordlet/runtimehooks/protocol/kubeqos_context.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2162      +/-   ##
==========================================
- Coverage   67.89%   67.88%   -0.01%     
==========================================
  Files         443      443              
  Lines       41920    41957      +37     
==========================================
+ Hits        28463    28484      +21     
- Misses      11006    11017      +11     
- Partials     2451     2456       +5     
Flag Coverage Δ
unittests 67.88% <86.20%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0fa719d into koordinator-sh:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants