Skip to content

scheduler: support scheduler config v1#2167

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
AdrianMachao:bugfix/support-scheduler-v1
Aug 15, 2024
Merged

scheduler: support scheduler config v1#2167
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
AdrianMachao:bugfix/support-scheduler-v1

Conversation

@AdrianMachao
Copy link
Contributor

Ⅰ. Describe what this PR does

support scheduler config v1

Ⅱ. Does this pull request fix one issue?

fix #2165

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.88%. Comparing base (b5b8abf) to head (7c1db4f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   67.88%   67.88%           
=======================================
  Files         443      443           
  Lines       41921    41921           
=======================================
+ Hits        28456    28459    +3     
+ Misses      11012    11006    -6     
- Partials     2453     2456    +3     
Flag Coverage Δ
unittests 67.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdrianMachao
Copy link
Contributor Author

/assign @buptcozy @eahydra @ZiMengSheng

@saintube
Copy link
Member

@AdrianMachao Good job!
Could you please add the example config under the directory config/manager? So we can verify the upgrade during the E2E tests.

@AdrianMachao
Copy link
Contributor Author

@AdrianMachao Good job! Could you please add the example config under the directory config/manager? So we can verify the upgrade during the E2E tests.

ok, I will upgrade config/manager/scheduler-config.yaml version to v1

Signed-off-by: machao <986292120@qq.com>
@AdrianMachao AdrianMachao force-pushed the bugfix/support-scheduler-v1 branch from abfef1a to 7c1db4f Compare August 14, 2024 11:18
@AdrianMachao
Copy link
Contributor Author

AdrianMachao commented Aug 14, 2024

@AdrianMachao Good job! Could you please add the example config under the directory config/manager? So we can verify the upgrade during the E2E tests.

updated, is it that?

@saintube
Copy link
Member

@AdrianMachao Good job! Could you please add the example config under the directory config/manager? So we can verify the upgrade during the E2E tests.

updated, is it that?

Yes.
/lgtm
PTAL /cc @ZiMengSheng

@ZiMengSheng
Copy link
Member

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d376bf5 into koordinator-sh:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] v1beta3 doesn't support PreEnqueue extension point !!

5 participants