Skip to content

scheduler: suppport amd.com/gpu#2174

Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
ZiMengSheng:amd
Sep 2, 2024
Merged

scheduler: suppport amd.com/gpu#2174
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
ZiMengSheng:amd

Conversation

@ZiMengSheng
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (6074e77) to head (7465f74).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2174   +/-   ##
=======================================
  Coverage   67.68%   67.69%           
=======================================
  Files         446      446           
  Lines       42694    42694           
=======================================
+ Hits        28898    28900    +2     
+ Misses      11276    11275    -1     
+ Partials     2520     2519    -1     
Flag Coverage Δ
unittests 67.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Sep 2, 2024

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot removed the lgtm label Sep 2, 2024
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@hormes hormes added lgtm and removed size/XS labels Sep 2, 2024
@koordinator-bot koordinator-bot bot merged commit 49185b2 into koordinator-sh:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants