Skip to content

scheduler: assure only gpu will allocate by topology#2178

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:effective_allocate_by_topology
Aug 28, 2024
Merged

scheduler: assure only gpu will allocate by topology#2178
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:effective_allocate_by_topology

Conversation

@ZiMengSheng
Copy link
Member

Ⅰ. Describe what this PR does

Currently, allocate by topology is time-consuming, we don't need it when deviceType isn't gpu.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.90%. Comparing base (e1d910a) to head (8e0a3ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2178   +/-   ##
=======================================
  Coverage   67.90%   67.90%           
=======================================
  Files         443      443           
  Lines       41967    41974    +7     
=======================================
+ Hits        28496    28502    +6     
- Misses      11016    11018    +2     
+ Partials     2455     2454    -1     
Flag Coverage Δ
unittests 67.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songtao98
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Member Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0ddf353 into koordinator-sh:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants