Skip to content

scheduler: elastic quota ignore terminating pod immediately#2180

Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
TaoYang526:ignore-terminating-pod-immediately
Sep 2, 2024
Merged

scheduler: elastic quota ignore terminating pod immediately#2180
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
TaoYang526:ignore-terminating-pod-immediately

Conversation

@TaoYang526
Copy link
Contributor

@TaoYang526 TaoYang526 commented Aug 29, 2024

Ⅰ. Describe what this PR does

proposal: #2179
introduce a feature gate called ElasticQuotaImmediateIgnoreTerminatingPod, which would allow to bypass the deletion grace period and immediately ignore terminating pods.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and buptcozy August 29, 2024 02:43
@saintube saintube requested a review from shaloulcy August 29, 2024 02:45
@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (e15a68c) to head (76c2248).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2180      +/-   ##
==========================================
- Coverage   67.69%   67.69%   -0.01%     
==========================================
  Files         446      446              
  Lines       42686    42688       +2     
==========================================
- Hits        28898    28896       -2     
- Misses      11269    11272       +3     
- Partials     2519     2520       +1     
Flag Coverage Δ
unittests 67.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

@TaoYang526 Thanks for your contributions!
Before the PR gets reviewed, please fix the DCO check for your commits.
https://github.com/koordinator-sh/koordinator/pull/2180/checks?check_run_id=29400771605

@TaoYang526 TaoYang526 force-pushed the ignore-terminating-pod-immediately branch from 9b99155 to d4ea9b6 Compare August 29, 2024 10:08
@TaoYang526
Copy link
Contributor Author

@saintube Thanks for reminding that, just updated.

@TaoYang526
Copy link
Contributor Author

/retest

@koordinator-bot
Copy link

@TaoYang526: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TaoYang526 TaoYang526 force-pushed the ignore-terminating-pod-immediately branch from d4ea9b6 to 2db66d1 Compare August 30, 2024 00:34
@saintube
Copy link
Member

/ok-to-test
/retest

@saintube
Copy link
Member

/lgtm
PTAL /cc @shaloulcy @ZiMengSheng @hormes

Signed-off-by: yangtao.yt <yangtao.yt@alibaba-inc.com>
@hormes hormes force-pushed the ignore-terminating-pod-immediately branch from 6944e2e to 4cad8da Compare September 2, 2024 02:51
@hormes
Copy link
Member

hormes commented Sep 2, 2024

/lgtm
/approve

@koordinator-bot koordinator-bot bot removed the lgtm label Sep 2, 2024
@hormes hormes removed the approved label Sep 2, 2024
@hormes
Copy link
Member

hormes commented Sep 2, 2024

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Sep 2, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7a1559b into koordinator-sh:main Sep 2, 2024
@TaoYang526
Copy link
Contributor Author

Thanks @hormes @saintube for the review and commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants