Skip to content

scheduler: permit other plugin to set numaAffinity#2182

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:numaAffinity
Sep 2, 2024
Merged

scheduler: permit other plugin to set numaAffinity#2182
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:numaAffinity

Conversation

@ZiMengSheng
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base (f7c6414) to head (bac8625).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../scheduler/frameworkext/topologymanager/manager.go 0.00% 8 Missing ⚠️
...kg/scheduler/frameworkext/topologymanager/store.go 0.00% 3 Missing ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2182      +/-   ##
==========================================
- Coverage   67.89%   67.77%   -0.13%     
==========================================
  Files         443      444       +1     
  Lines       41984    42206     +222     
==========================================
+ Hits        28506    28605      +99     
- Misses      11022    11117      +95     
- Partials     2456     2484      +28     
Flag Coverage Δ
unittests 67.77% <36.84%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit cb89d6d into koordinator-sh:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants