Skip to content

koordlet: support init container for CPUSetAllocator#2349

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zwzhang0107:init-container-cpuset
Feb 27, 2025
Merged

koordlet: support init container for CPUSetAllocator#2349
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zwzhang0107:init-container-cpuset

Conversation

@zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Feb 26, 2025

Ⅰ. Describe what this PR does

Set cpuset for init container in CPUSetAllocator.

Ⅱ. Does this pull request fix one issue?

#2350

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@zwzhang0107 zwzhang0107 requested a review from saintube February 26, 2025 09:38
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 37.68116% with 43 lines in your changes missing coverage. Please review.

Project coverage is 65.90%. Comparing base (7a9e18c) to head (8aa668a).
Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
...oordlet/runtimehooks/protocol/container_context.go 0.00% 31 Missing ⚠️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 57.14% 6 Missing and 3 partials ⚠️
pkg/koordlet/util/pod.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
- Coverage   65.96%   65.90%   -0.06%     
==========================================
  Files         466      466              
  Lines       54888    54943      +55     
==========================================
+ Hits        36205    36210       +5     
- Misses      16072    16115      +43     
- Partials     2611     2618       +7     
Flag Coverage Δ
unittests 65.90% <37.68%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@zwzhang0107 zwzhang0107 force-pushed the init-container-cpuset branch from a644ec0 to 8aa668a Compare February 26, 2025 11:54
@saintube saintube added the lgtm label Feb 26, 2025
@koordinator-bot koordinator-bot bot merged commit e547931 into koordinator-sh:main Feb 27, 2025
22 checks passed
@ZiMengSheng ZiMengSheng added this to the v1.7 milestone Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants