Skip to content

docker-proxy: support createContainer and stopSandbox hook#236

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZYecho:docker-proxy-2
Jun 15, 2022
Merged

docker-proxy: support createContainer and stopSandbox hook#236
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZYecho:docker-proxy-2

Conversation

@ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jun 9, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

fix #217 #218

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng June 9, 2022 03:58
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #236 (b43b1b6) into main (d139458) will increase coverage by 1.51%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   58.37%   59.88%   +1.51%     
==========================================
  Files         103      103              
  Lines        9575     9608      +33     
==========================================
+ Hits         5589     5754     +165     
+ Misses       3521     3366     -155     
- Partials      465      488      +23     
Flag Coverage Δ
unittests 59.88% <70.00%> (+1.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/server.go 20.63% <0.00%> (+20.63%) ⬆️
pkg/runtimeproxy/server/docker/handler.go 32.45% <41.37%> (+32.45%) ⬆️
pkg/runtimeproxy/server/docker/utils.go 80.90% <100.00%> (+50.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d139458...b43b1b6. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZYecho , please fix the error format here in this PR as well, thanks.

if err != nil {
klog.Fatal("Failed to create the lis %v", err)
}

@ZYecho ZYecho force-pushed the docker-proxy-2 branch 3 times, most recently from 9dc3a52 to 3c05382 Compare June 14, 2022 09:56
@jasonliu747 jasonliu747 requested a review from cheimu June 14, 2022 12:44
@cheimu
Copy link
Member

cheimu commented Jun 14, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 14, 2022
@koordinator-bot koordinator-bot bot removed the lgtm label Jun 15, 2022
@ZYecho ZYecho requested review from jasonliu747 and removed request for cheimu June 15, 2022 02:53
@ZYecho ZYecho requested a review from cheimu June 15, 2022 02:53
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Jun 15, 2022
@ZYecho ZYecho force-pushed the docker-proxy-2 branch 7 times, most recently from 24bacf9 to 81d8d7d Compare June 15, 2022 09:44
@cheimu
Copy link
Member

cheimu commented Jun 15, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 15, 2022
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Jun 15, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheimu
Copy link
Member

cheimu commented Jun 15, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 15, 2022
@koordinator-bot koordinator-bot bot merged commit cef1028 into koordinator-sh:main Jun 15, 2022
@ZYecho ZYecho deleted the docker-proxy-2 branch June 15, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[support request] create container hook [BUG] Add Docker case in runtimeproxy document

4 participants