docker-proxy: support createContainer and stopSandbox hook#236
docker-proxy: support createContainer and stopSandbox hook#236koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 58.37% 59.88% +1.51%
==========================================
Files 103 103
Lines 9575 9608 +33
==========================================
+ Hits 5589 5754 +165
+ Misses 3521 3366 -155
- Partials 465 488 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jasonliu747
left a comment
There was a problem hiding this comment.
Hi @ZYecho , please fix the error format here in this PR as well, thanks.
koordinator/pkg/runtimeproxy/server/docker/server.go
Lines 189 to 191 in c298bd1
9dc3a52 to
3c05382
Compare
|
/lgtm |
24bacf9 to
81d8d7d
Compare
|
/lgtm |
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
81d8d7d to
b43b1b6
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com
Ⅰ. Describe what this PR does
fix #217 #218
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews