Skip to content

Fix: Regenerate runtime api to fix typo#238

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
cheimu:fix/runtime-api-typo
Jun 9, 2022
Merged

Fix: Regenerate runtime api to fix typo#238
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
cheimu:fix/runtime-api-typo

Conversation

@cheimu
Copy link
Member

@cheimu cheimu commented Jun 9, 2022

Signed-off-by: yimo yimo@xiaohongshu.com

Ⅰ. Describe what this PR does

Fix typos within runtime api.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: yimo <yimo@xiaohongshu.com>
@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng June 9, 2022 07:00
@cheimu
Copy link
Member Author

cheimu commented Jun 9, 2022

@ZYecho

@jasonliu747
Copy link
Member

/cc @honpey @ZYecho

@koordinator-bot koordinator-bot bot requested review from ZYecho and honpey June 9, 2022 07:03
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #238 (23147cc) into main (5a69a22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files          99       99           
  Lines        9277     9277           
=======================================
  Hits         5489     5489           
  Misses       3331     3331           
  Partials      457      457           
Flag Coverage Δ
unittests 59.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a69a22...23147cc. Read the comment docs.

@zwzhang0107
Copy link
Contributor

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jun 9, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 9cbe6a9 into koordinator-sh:main Jun 9, 2022
@jasonliu747 jasonliu747 added this to the v0.5 milestone Jun 10, 2022
@cheimu cheimu mentioned this pull request Jun 13, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants