Skip to content

scheduler: change quota info to rw lock#2421

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:fix_quota_lock
Apr 23, 2025
Merged

scheduler: change quota info to rw lock#2421
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
shaloulcy:fix_quota_lock

Conversation

@shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

Signed-off-by: shaloulcy <lcy041546@gmail.com>
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (c94d81d) to head (49d7528).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
.../scheduler/plugins/elasticquota/core/quota_info.go 91.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.02%     
==========================================
  Files         470      470              
  Lines       55561    55561              
==========================================
- Hits        36685    36676       -9     
- Misses      16226    16235       +9     
  Partials     2650     2650              
Flag Coverage Δ
unittests 66.01% <91.30%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koordinator-bot koordinator-bot bot merged commit b20dca2 into koordinator-sh:main Apr 23, 2025
19 of 22 checks passed
@ZiMengSheng ZiMengSheng added this to the v1.7 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants