Skip to content

scheduler: rename leastRequestedScore func#2422

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
googs1025:chore_rename
Apr 28, 2025
Merged

scheduler: rename leastRequestedScore func#2422
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
googs1025:chore_rename

Conversation

@googs1025
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

  • leastRequestedScore func name seems to be misleading, we use used for calculation, not requested

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (b20dca2) to head (bf75ef8).
Report is 70 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2422   +/-   ##
=======================================
  Coverage   66.01%   66.02%           
=======================================
  Files         470      470           
  Lines       55561    55561           
=======================================
+ Hits        36679    36682    +3     
+ Misses      16233    16228    -5     
- Partials     2649     2651    +2     
Flag Coverage Δ
unittests 66.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saintube saintube changed the title rename leastRequestedScore func scheduler: rename leastRequestedScore func Apr 28, 2025
Signed-off-by: googs1025 <googs1025@gmail.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 66fa5ab into koordinator-sh:main Apr 28, 2025
22 checks passed
@ZiMengSheng ZiMengSheng added this to the v1.7 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants