Skip to content

scheduler: optimize secondary device well planned#2425

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:secondary_device
Apr 29, 2025
Merged

scheduler: optimize secondary device well planned#2425
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:secondary_device

Conversation

@ZiMengSheng
Copy link
Member

@ZiMengSheng ZiMengSheng commented Apr 29, 2025

Ⅰ. Describe what this PR does

In a production environment, sufficient VF resources are usually planned for the GPU. Under this condition, you can skip the resource check of the VF in the Filter stage and only do it in the Reserve stage.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (66fa5ab) to head (af341cc).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
+ Coverage   66.01%   66.02%   +0.01%     
==========================================
  Files         470      470              
  Lines       55561    55564       +3     
==========================================
+ Hits        36679    36688       +9     
+ Misses      16233    16226       -7     
- Partials     2649     2650       +1     
Flag Coverage Δ
unittests 66.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Recommended to add some description about this API.

@ZiMengSheng
Copy link
Member Author

/approve

@ZiMengSheng
Copy link
Member Author

/assign @FillZpp

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: saintube, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 09ba992 into koordinator-sh:main Apr 29, 2025
22 of 23 checks passed
@ZiMengSheng ZiMengSheng added this to the v1.7 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants