Skip to content

descheduler: return the unmatched cases first#2435

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
googs1025:sort
May 12, 2025
Merged

descheduler: return the unmatched cases first#2435
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
googs1025:sort

Conversation

@googs1025
Copy link
Member

Ⅰ. Describe what this PR does

We should return the unmatched cases first,and leave the filter method for last, because it is computationally expensive.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and eahydra May 9, 2025 11:47
Signed-off-by: googs1025 <googs1025@gmail.com>
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (583f723) to head (b814aeb).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2435      +/-   ##
==========================================
- Coverage   66.04%   66.02%   -0.03%     
==========================================
  Files         470      470              
  Lines       55580    55580              
==========================================
- Hits        36709    36695      -14     
- Misses      16223    16235      +12     
- Partials     2648     2650       +2     
Flag Coverage Δ
unittests 66.02% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saintube saintube changed the title fix: return the unmatched cases first descheduler: return the unmatched cases first May 12, 2025
@saintube
Copy link
Member

PTAL /cc @songtao98

@songtao98
Copy link
Contributor

@googs1025 yes, I think this is a nice optimization in theory. However, have you already meet any performance bottleneck? It would be great if some real cases can be provided :)

/lgtm

@songtao98
Copy link
Contributor

/approve

@googs1025
Copy link
Member Author

@googs1025 yes, I think this is a nice optimization in theory. However, have you already meet any performance bottleneck? It would be great if some real cases can be provided :)

Not yet, I just noticed a fix from the code level 😄

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: songtao98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 274d3bf into koordinator-sh:main May 12, 2025
22 of 25 checks passed
@ZiMengSheng ZiMengSheng added this to the v1.7 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants