descheduler: return the unmatched cases first#2435
descheduler: return the unmatched cases first#2435koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Signed-off-by: googs1025 <googs1025@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2435 +/- ##
==========================================
- Coverage 66.04% 66.02% -0.03%
==========================================
Files 470 470
Lines 55580 55580
==========================================
- Hits 36709 36695 -14
- Misses 16223 16235 +12
- Partials 2648 2650 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PTAL /cc @songtao98 |
|
@googs1025 yes, I think this is a nice optimization in theory. However, have you already meet any performance bottleneck? It would be great if some real cases can be provided :) /lgtm |
|
/approve |
Not yet, I just noticed a fix from the code level 😄 |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: songtao98 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
274d3bf
into
koordinator-sh:main
Ⅰ. Describe what this PR does
We should return the unmatched cases first,and leave the filter method for last, because it is computationally expensive.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test