Skip to content

Add Defer os.Remove before starting runtime proxy server #247

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
cheimu:fix/fix-runtime-proxy-starting-panic
Jun 13, 2022
Merged

Add Defer os.Remove before starting runtime proxy server #247
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
cheimu:fix/fix-runtime-proxy-starting-panic

Conversation

@cheimu
Copy link
Member

@cheimu cheimu commented Jun 11, 2022

Signed-off-by: Cheimu yimo@xiaohongshu.com

Ⅰ. Describe what this PR does

Try to clean up runtime proxy endpoint socket file when runtime proxy got unexpected panic

Ⅱ. Does this pull request fix one issue?

fixes #246

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@cheimu
Copy link
Member Author

cheimu commented Jun 11, 2022

/cc @ZYecho @honpey

@koordinator-bot koordinator-bot bot requested review from ZYecho and honpey June 11, 2022 08:16
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #247 (894967b) into main (c298bd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files          99       99           
  Lines        9277     9277           
=======================================
  Hits         5489     5489           
  Misses       3331     3331           
  Partials      457      457           
Flag Coverage Δ
unittests 59.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c298bd1...894967b. Read the comment docs.

@cheimu cheimu changed the title Unlink sock file before starting runtime proxy server Add Defer os.Remove before starting runtime proxy server Jun 11, 2022
@cheimu cheimu force-pushed the fix/fix-runtime-proxy-starting-panic branch from f3e1bf5 to 26e648b Compare June 11, 2022 09:49
@cheimu
Copy link
Member Author

cheimu commented Jun 11, 2022

/cc @jasonliu747

@koordinator-bot koordinator-bot bot requested a review from jasonliu747 June 11, 2022 09:49
@cheimu cheimu force-pushed the fix/fix-runtime-proxy-starting-panic branch from a24958b to 723b988 Compare June 11, 2022 10:13
Signed-off-by: Cheimu <xerhoneyfc@gmail.com>
@jasonliu747 jasonliu747 force-pushed the fix/fix-runtime-proxy-starting-panic branch from 723b988 to 894967b Compare June 11, 2022 13:59
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@honpey @ZYecho PTAL

@hormes
Copy link
Member

hormes commented Jun 13, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8910d29 into koordinator-sh:main Jun 13, 2022
@cheimu cheimu mentioned this pull request Jun 13, 2022
7 tasks
@jasonliu747 jasonliu747 modified the milestone: v0.5 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] If runtime proxy got restarted by panic, it won't restart successfully by current design

3 participants