scheduler: add loadaware plugins Aggregated Args Validate#2527
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Jul 16, 2025
Merged
scheduler: add loadaware plugins Aggregated Args Validate#2527koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Signed-off-by: googs1025 <googs1025@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
==========================================
- Coverage 66.24% 66.22% -0.03%
==========================================
Files 484 484
Lines 56768 56768
==========================================
- Hits 37606 37594 -12
- Misses 16429 16438 +9
- Partials 2733 2736 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ZiMengSheng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qinfustu
added a commit
to qinfustu/koordinator
that referenced
this pull request
Jul 22, 2025
…be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> Signed-off-by: qinfustu <fu_qin_stu@163.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> colocationprofile: support namespace selector for ClusterColocationProfile in controller (koordinator-sh#2522) Signed-off-by: googs1025 <googs1025@gmail.com> webhook: add more info when deleting quota failed (koordinator-sh#2519) Signed-off-by: googs1025 <googs1025@gmail.com> scheduler: add loadaware plugins Aggregated Args Validate (koordinator-sh#2527) Signed-off-by: googs1025 <googs1025@gmail.com> proposal: network topology aware scheduling (koordinator-sh#2474) Signed-off-by: yangchao <yangchao10@xiaomi.com> Co-authored-by: wangjianyu <zmsjianyu@gmail.com> scheduler: fix flaky test (koordinator-sh#2532) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> scheduler: loadaware support force estimated duration and other improvements (koordinator-sh#2531) Signed-off-by: zheng-weihao <zheng-weihao@outlook.com> remove inactive approve to smooth review process (koordinator-sh#2534) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> koordlet: fix Histogram maxValue error (koordinator-sh#2540) Signed-off-by: cntigers <cntigers@outlook.com> scheduler: add ElasticQuota arg to control MinQuotaScale (koordinator-sh#2542) Signed-off-by: qinfustu <fu_qin_stu@163.com> scheduler: only requeue gang when gangWorth and by activate (koordinator-sh#2537) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> scheduler: fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com>
qinfustu
added a commit
to qinfustu/koordinator
that referenced
this pull request
Jul 22, 2025
…be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> Signed-off-by: qinfustu <fu_qin_stu@163.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> scheduler: fix unhandled timeout in SchedulerMonitor (koordinator-sh#2518) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> manager: Optimize ConfigMap update event handling by reordering checks (koordinator-sh#2511) Signed-off-by: googs1025 <googs1025@gmail.com> koord-descheduler: use RWMutex instead of use Mutex (koordinator-sh#2514) Signed-off-by: googs1025 <googs1025@gmail.com> Update descheduler approvers (koordinator-sh#2520) Signed-off-by: songtao98 <songtao2603060@gmail.com> scheduler: add pre-allocation api, revise reservation interfaces (koordinator-sh#2513) Signed-off-by: saintube <saintube@foxmail.com> Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com> koordlet: adding cpu.max.burst comments (koordinator-sh#2524) Signed-off-by: song <rongxiang.song@gientech.com> Co-authored-by: song <rongxiang.song@gientech.com> colocationprofile: support namespace selector for ClusterColocationProfile in controller (koordinator-sh#2522) Signed-off-by: googs1025 <googs1025@gmail.com> webhook: add more info when deleting quota failed (koordinator-sh#2519) Signed-off-by: googs1025 <googs1025@gmail.com> scheduler: add loadaware plugins Aggregated Args Validate (koordinator-sh#2527) Signed-off-by: googs1025 <googs1025@gmail.com> proposal: network topology aware scheduling (koordinator-sh#2474) Signed-off-by: yangchao <yangchao10@xiaomi.com> Co-authored-by: wangjianyu <zmsjianyu@gmail.com> scheduler: fix flaky test (koordinator-sh#2532) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> scheduler: loadaware support force estimated duration and other improvements (koordinator-sh#2531) Signed-off-by: zheng-weihao <zheng-weihao@outlook.com> remove inactive approve to smooth review process (koordinator-sh#2534) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> koordlet: fix Histogram maxValue error (koordinator-sh#2540) Signed-off-by: cntigers <cntigers@outlook.com> scheduler: add ElasticQuota arg to control MinQuotaScale (koordinator-sh#2542) Signed-off-by: qinfustu <fu_qin_stu@163.com> scheduler: only requeue gang when gangWorth and by activate (koordinator-sh#2537) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> scheduler: fix after deleting an ElasticQuota, its associated metrics can still be queried Signed-off-by: qinfustu <fu_qin_stu@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test