Skip to content

cmd: refactor SecureServing.Serve return in scheduler and descheduler#2551

Merged
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
googs1025:stopch
Jul 28, 2025
Merged

cmd: refactor SecureServing.Serve return in scheduler and descheduler#2551
koordinator-bot[bot] merged 2 commits intokoordinator-sh:mainfrom
googs1025:stopch

Conversation

@googs1025
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…erve

Signed-off-by: googs1025 <googs1025@gmail.com>
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.35%. Comparing base (30ea8bb) to head (6b1314a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2551      +/-   ##
==========================================
- Coverage   66.36%   66.35%   -0.02%     
==========================================
  Files         485      485              
  Lines       57098    57098              
==========================================
- Hits        37893    37887       -6     
- Misses      16453    16463      +10     
+ Partials     2752     2748       -4     
Flag Coverage Δ
unittests 66.35% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZiMengSheng
Copy link
Member

/lgtm
/approve

@koordinator-bot koordinator-bot bot removed the lgtm label Jul 28, 2025
@ZiMengSheng
Copy link
Member

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Jul 28, 2025
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b2f030c into koordinator-sh:main Jul 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants