refactor: remove useless field in NodeSLOReconciler#259
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Jun 20, 2022
Merged
refactor: remove useless field in NodeSLOReconciler#259koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 60.52% 60.52%
=======================================
Files 103 103
Lines 9602 9602
=======================================
Hits 5812 5812
Misses 3304 3304
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
saintube
reviewed
Jun 19, 2022
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Liu jasonliu747@gmail.com
Ⅰ. Describe what this PR does
logris no longer needed since we haveklogⅡ. Does this pull request fix one issue?
This PR should close #185
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews