Skip to content

scheduler: don't invoke SnapshotSharedLister in parallizer#2625

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:fixnodeinfolister
Sep 23, 2025
Merged

scheduler: don't invoke SnapshotSharedLister in parallizer#2625
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:fixnodeinfolister

Conversation

@ZiMengSheng
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.49%. Comparing base (1845a44) to head (febe346).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2625   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files         491      491           
  Lines       59103    59104    +1     
=======================================
+ Hits        39298    39300    +2     
+ Misses      16944    16942    -2     
- Partials     2861     2862    +1     
Flag Coverage Δ
unittests 66.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ZiMengSheng
Copy link
Member Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0b67a47 into koordinator-sh:main Sep 23, 2025
22 checks passed
qinfustu pushed a commit to qinfustu/koordinator that referenced this pull request Sep 23, 2025
…or-sh#2625)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
qinfustu added a commit to qinfustu/koordinator that referenced this pull request Sep 23, 2025
Signed-off-by: qinfustu <30459241+qinfustu@users.noreply.github.com>

scheduler: don't invoke SnapshotSharedLister in parallizer (koordinator-sh#2625)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: support ignore nominatedPods of same job (koordinator-sh#2628)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: distinguish preemption failure&success in nominatingInfo (koordinator-sh#2629)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

koordlet: add mainline kernel support for IsCoreSchedSupported() (koordinator-sh#2621)

Signed-off-by: hwenwur <hwenwur@gmail.com>

scheduler: fix deviceShare UT (koordinator-sh#2631)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
qinfustu added a commit to qinfustu/koordinator that referenced this pull request Sep 24, 2025
Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

scheduler: during scheduling, it must consider whether hami-core is installed on the nodes (koordinator-sh#2577)

Signed-off-by: qinfustu <fu_qin_stu@163.com>

fix: podGroup not add to queue when pg not fount in PodGroupControlle… (koordinator-sh#2580)

Signed-off-by: yangchao10 <yangchao10@xiaomi.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

chore: fix typo for RegisterTypeNodeMetadata (koordinator-sh#2584)

Signed-off-by: qingyuan.zheng <460189852@qq.com>

webhook: fix elasticquota validation error for min > max (koordinator-sh#2586)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>

koordlet: support enhanced group identity for gpu (koordinator-sh#2583)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

scheduler: preprocess unmatch reservation's allocated (koordinator-sh#2589)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

manager: support batch resource limit of nodeCapacity (koordinator-sh#2588)

Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>

apis: adapt to both v1alpha1&v1alpha2 noderesourcetopology (koordinator-sh#2593)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

scheduler: collect schedule pod result in metrics (koordinator-sh#2585)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

scheduler: add pre-allocation nominator (koordinator-sh#2592)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

koordlet: fix typo and add memory-ratio resource for buildXPUDevice() (koordinator-sh#2599)

Signed-off-by: ZhuZhezz <zzhuzju@163.com>

scheduler: don't invoke SnapshotSharedLister in parallizer (koordinator-sh#2600)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

scheduler: add questionedObjectKet and topologyKeyToExplain (koordinator-sh#2601)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

apis: add scheduleExplanation CRD (koordinator-sh#2602)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

scheduler: improve load aware perf by resources cache and vectorization (koordinator-sh#2582)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

koordlet: fix koordlet panic randomly,caused by node info not ready (koordinator-sh#2597)

Signed-off-by: zhengj5 <zhengj5@trip.com>
Co-authored-by: zhengj5 <zhengj5@trip.com>

scheduler: loadaware support dominantResourceWeight (koordinator-sh#2603)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

koordlet: fix path for sched_idle_saver_wmark (koordinator-sh#2611)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

provides GPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

revert

Signed-off-by: qinfustu <fu_qin_stu@163.com>

revert2

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

scheduler: during scheduling, it must consider whether hami-core is installed on the nodes (koordinator-sh#2577)

Signed-off-by: qinfustu <fu_qin_stu@163.com>

fix: podGroup not add to queue when pg not fount in PodGroupControlle… (koordinator-sh#2580)

Signed-off-by: yangchao10 <yangchao10@xiaomi.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

chore: fix typo for RegisterTypeNodeMetadata (koordinator-sh#2584)

Signed-off-by: qingyuan.zheng <460189852@qq.com>

webhook: fix elasticquota validation error for min > max (koordinator-sh#2586)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>

koordlet: support enhanced group identity for gpu (koordinator-sh#2583)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

scheduler: preprocess unmatch reservation's allocated (koordinator-sh#2589)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

manager: support batch resource limit of nodeCapacity (koordinator-sh#2588)

Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>

apis: adapt to both v1alpha1&v1alpha2 noderesourcetopology (koordinator-sh#2593)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

scheduler: collect schedule pod result in metrics (koordinator-sh#2585)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

scheduler: add pre-allocation nominator (koordinator-sh#2592)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

koordlet: fix typo and add memory-ratio resource for buildXPUDevice() (koordinator-sh#2599)

Signed-off-by: ZhuZhezz <zzhuzju@163.com>

scheduler: don't invoke SnapshotSharedLister in parallizer (koordinator-sh#2600)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

scheduler: add questionedObjectKet and topologyKeyToExplain (koordinator-sh#2601)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

apis: add scheduleExplanation CRD (koordinator-sh#2602)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>

scheduler: improve load aware perf by resources cache and vectorization (koordinator-sh#2582)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

koordlet: fix koordlet panic randomly,caused by node info not ready (koordinator-sh#2597)

Signed-off-by: zhengj5 <zhengj5@trip.com>
Co-authored-by: zhengj5 <zhengj5@trip.com>

scheduler: loadaware support dominantResourceWeight (koordinator-sh#2603)

Signed-off-by: zheng-weihao <zheng-weihao@outlook.com>
Co-authored-by: wangjianyu <zmsjianyu@gmail.com>

koordlet: fix path for sched_idle_saver_wmark (koordinator-sh#2611)

Signed-off-by: saintube <saintube@foxmail.com>
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>

provides GPU allocation and utilization metrics

Signed-off-by: qinfustu <fu_qin_stu@163.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <30459241+qinfustu@users.noreply.github.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <30459241+qinfustu@users.noreply.github.com>

provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <30459241+qinfustu@users.noreply.github.com>

scheduler: don't invoke SnapshotSharedLister in parallizer (koordinator-sh#2625)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: support ignore nominatedPods of same job (koordinator-sh#2628)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: distinguish preemption failure&success in nominatingInfo (koordinator-sh#2629)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

koordlet: add mainline kernel support for IsCoreSchedSupported() (koordinator-sh#2621)

Signed-off-by: hwenwur <hwenwur@gmail.com>

scheduler: fix deviceShare UT (koordinator-sh#2631)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

all: provides vGPU allocation and utilization metrics

Signed-off-by: qinfustu <30459241+qinfustu@users.noreply.github.com>

scheduler: don't invoke SnapshotSharedLister in parallizer (koordinator-sh#2625)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: support ignore nominatedPods of same job (koordinator-sh#2628)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: distinguish preemption failure&success in nominatingInfo (koordinator-sh#2629)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

koordlet: add mainline kernel support for IsCoreSchedSupported() (koordinator-sh#2621)

Signed-off-by: hwenwur <hwenwur@gmail.com>

scheduler: fix deviceShare UT (koordinator-sh#2631)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>

scheduler: support customize preemption diagnosis (koordinator-sh#2632)

Signed-off-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: 乔普 <wangjianyu.wjy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants