Skip to content

scheduler: add scheduling hint plugin#2657

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:scheduler-add-hint-plugin
Oct 21, 2025
Merged

scheduler: add scheduling hint plugin#2657
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:scheduler-add-hint-plugin

Conversation

@saintube
Copy link
Member

@saintube saintube commented Oct 21, 2025

Ⅰ. Describe what this PR does

Add the plugin SchedulingHint to apply the hint state according to pod annotations.
Fix the typo for the scheduling hint API.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the scheduler-add-hint-plugin branch from 1263b4b to a395eac Compare October 21, 2025 09:19
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.70%. Comparing base (e8c879c) to head (1a5ac6c).
⚠️ Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
...cheduler/plugins/schedulinghint/scheduling_hint.go 91.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
+ Coverage   66.68%   66.70%   +0.02%     
==========================================
  Files         503      504       +1     
  Lines       61247    61283      +36     
==========================================
+ Hits        40840    40879      +39     
+ Misses      17447    17446       -1     
+ Partials     2960     2958       -2     
Flag Coverage Δ
unittests 66.70% <91.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saintube saintube force-pushed the scheduler-add-hint-plugin branch from a395eac to 9c44ce6 Compare October 21, 2025 09:29
Co-authored-by: shenxin <rougang.hrg@alibaba-inc.com>
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-add-hint-plugin branch from 9c44ce6 to 1a5ac6c Compare October 21, 2025 09:39
@ZiMengSheng
Copy link
Member

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 76436ec into koordinator-sh:main Oct 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants