Skip to content

api: add reservation API#276

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:add-reservation-api
Jun 21, 2022
Merged

api: add reservation API#276
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:add-reservation-api

Conversation

@saintube
Copy link
Member

@saintube saintube commented Jun 21, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Add Reservation API

Ⅱ. Does this pull request fix one issue?

#188

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

This API follows the design in #241 .

@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng June 21, 2022 03:41
@jasonliu747 jasonliu747 added this to the v0.5 milestone Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #276 (b39204e) into main (1035de1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   61.06%   61.06%           
=======================================
  Files         103      103           
  Lines        9599     9599           
=======================================
  Hits         5862     5862           
  Misses       3250     3250           
  Partials      487      487           
Flag Coverage Δ
unittests 61.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtime/handler/docker_runtime.go
pkg/runtime/runtime.go
pkg/runtime/handler/fake_runtime.go
pkg/runtime/handler/containerd_runtime.go
pkg/util/runtime/handler/containerd_runtime.go 61.11% <0.00%> (ø)
pkg/util/runtime/handler/docker_runtime.go 90.47% <0.00%> (ø)
pkg/util/runtime/runtime.go 76.47% <0.00%> (ø)
pkg/util/runtime/handler/fake_runtime.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1035de1...b39204e. Read the comment docs.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the add-reservation-api branch from 28ce923 to b39204e Compare June 21, 2022 05:31
@eahydra
Copy link
Member

eahydra commented Jun 21, 2022

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 21, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube requested a review from eahydra June 21, 2022 05:55
@hormes
Copy link
Member

hormes commented Jun 21, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1caf1cd into koordinator-sh:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants