Skip to content

proposal: Inference Orchestration Enhancement with Grove Integration#2777

Merged
ZiMengSheng merged 1 commit intokoordinator-sh:mainfrom
kangclzjc:grove-proposal
Feb 25, 2026
Merged

proposal: Inference Orchestration Enhancement with Grove Integration#2777
ZiMengSheng merged 1 commit intokoordinator-sh:mainfrom
kangclzjc:grove-proposal

Conversation

@kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

This proposal aims to enhance Koordinator's inference orchestration capabilities by integrating with Grove, an open-source Kubernetes enhancement for network topology-aware gang scheduling and autoscaling specifically designed for AI inference workloads.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.89%. Comparing base (449444c) to head (bacf754).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
- Coverage   67.91%   67.89%   -0.03%     
==========================================
  Files         513      513              
  Lines       52283    52283              
==========================================
- Hits        35510    35499      -11     
- Misses      13725    13734       +9     
- Partials     3048     3050       +2     
Flag Coverage Δ
unittests 67.89% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saintube saintube self-requested a review January 16, 2026 03:39
@saintube
Copy link
Member

Good job!
/lgtm

@saintube
Copy link
Member

PTAL /cc @ZiMengSheng

@ZiMengSheng
Copy link
Member

/approve

@koordinator-bot koordinator-bot bot added approved and removed lgtm labels Feb 24, 2026
Signed-off-by: Kang Zhang <kangz@nvidia.com>
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZiMengSheng ZiMengSheng enabled auto-merge (squash) February 25, 2026 02:47
@ZiMengSheng
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Feb 25, 2026
@ZiMengSheng ZiMengSheng merged commit 1399086 into koordinator-sh:main Feb 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants