koordlet: support eviction trigger by allocatable by lijunxin559 · Pull Request #2780 · koordinator-sh/koordinator

lijunxin559 · 2026-01-16T03:36:17Z

Ⅰ. Describe what this PR does

For the mid/batch resources provided by slo-manager, as they are oversold on the basis of prod resources, when slo manager's node water level is too high or the slo config configuration changes, the mid/batch resources for the next round of calculation updates may be significantly reduced. At this time, relying solely on the physical water level of the koordlet single machine side to trigger eviction may not be timely enough, and in severe cases, it may even cause machine downtime.

Ⅱ. Does this pull request fix one issue?

We provide allocatable based eviction method on a single machine side that evicts related pods and resource based on priority to avoid the above situation in advance.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

I have written necessary docs and comments
I have added necessary unit tests and integration tests
All checks passed in make test

codecov · 2026-01-16T09:17:51Z

Codecov Report

❌ Patch coverage is 84.96583% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.00%. Comparing base (f559bd1) to head (b624568).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../koordlet/qosmanager/plugins/cpuevict/cpu_evict.go	84.41%	19 Missing and 5 partials ⚠️
...let/qosmanager/plugins/memoryevict/memory_evict.go	89.79%	10 Missing and 5 partials ⚠️
pkg/koordlet/qosmanager/plugins/util/evict.go	88.00%	10 Missing and 5 partials ⚠️
pkg/util/extended_resource.go	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2780      +/-   ##
==========================================
+ Coverage   67.91%   68.00%   +0.08%     
==========================================
  Files         513      513              
  Lines       52258    52539     +281     
==========================================
+ Hits        35491    35728     +237     
- Misses      13719    13754      +35     
- Partials     3048     3057       +9

Flag	Coverage Δ
unittests	`68.00% <84.96%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pkg/koordlet/qosmanager/plugins/util/evict.go

pkg/koordlet/qosmanager/plugins/cpuevict/cpu_evict.go

pkg/koordlet/qosmanager/plugins/memoryevict/memory_evict.go

saintube

@lijunxin559 Could you please update the user manual for the new features?

lijunxin559 · 2026-01-20T09:23:47Z

@lijunxin559 Could you please update the user manual for the new features?
Ok, no problem. After testing this part of the functionality, I will further refine the usage details.

saintube · 2026-01-21T03:09:40Z

@lijunxin559 Do not forget to sign off your commit for the DCO check.

saintube · 2026-01-21T06:54:30Z

@lijunxin559 Please also revise the error message for the issue reported by #2782.

Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>

pkg/koordlet/qosmanager/plugins/cpuevict/cpu_evict.go

saintube · 2026-02-12T09:12:42Z

/lgtm
PTAL /cc @zwzhang0107

Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>

koordinator-bot · 2026-02-12T09:24:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from saintube and additionally assign zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saintube · 2026-02-12T09:52:51Z

/lgtm

AutuSnow · 2026-02-23T06:32:16Z

pkg/koordlet/qosmanager/plugins/cpuevict/cpu_evict.go

+			continue
+		}
+		// mid/batch are milli format on node: to confirm
+		rqValue := float32(qosmanagerUtil.ConvertQuantityToInt64(rt, rq))


The precision of float32 is only about 7 digits, which may result in loss of precision in memory scenarios

AutuSnow · 2026-02-23T06:34:29Z

pkg/koordlet/qosmanager/plugins/memoryevict/memory_evict.go

+			overall[rt] = rq
+			continue
+		}
+		rqValue := float32(qosmanagerUtil.ConvertQuantityToInt64(rt, rq))


AutuSnow · 2026-02-23T06:39:36Z

pkg/koordlet/qosmanager/plugins/util/evict.go

+		if _, ok := releaseTypes[target]; ok {
+			getPodResourceFuncs = append(getPodResourceFuncs, func(info *PodEvictInfo) map[ReleaseTargetType]corev1.ResourceList {
+				return map[ReleaseTargetType]corev1.ResourceList{
+					target: getPodResourceFunc(info),


Is this target a loop variable? Go1.22 has already solved this problem, but the Go version of this project is 1.21, so it should be noted

AutuSnow · 2026-02-23T06:41:20Z

pkg/koordlet/qosmanager/plugins/memoryevict/memory_evict.go

 		return nil, fmt.Errorf("unknown feature: %v", feature)
 	}
-	if err := isConfigValid(thresholdConfig, feature); err != nil {
+	if err := generateConfigCheck(feature)(thresholdConfig); err != nil {


GenerateConfigCheck returns nil for unknown features, so here we should directly panic

AutuSnow · 2026-02-23T06:48:18Z

pkg/koordlet/qosmanager/plugins/cpuevict/cpu_evict.go

+	requestedOnNode := make(corev1.ResourceList)
+	priorityThreshold := *thresholdConfig.AllocatableEvictPriorityThreshold
+	allocatableEvictThreshold := *thresholdConfig.CPUAllocatableEvictThresholdPercent
+	allocatableEvictLowerThreshold := *thresholdConfig.CPUAllocatableEvictLowerPercent


In the isAllocateableThresholdConfig Valid code, lowerPercent:=int64 (0), there will be no error when nil is detected in the judgment, and 0 will be used to continue the verification. However, if you attempt to dereference in this area, it will directly panic，The code for memory is the same

AutuSnow · 2026-02-23T06:51:04Z

The priority determination in the calculateFunc of CPU and Memory seems to be inconsistent. Is this within the expected range?

koordinator-bot bot requested review from ZiMengSheng, saintube and zwzhang0107 January 16, 2026 03:36

koordinator-bot bot added the size/XXL label Jan 16, 2026

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch 4 times, most recently from 28e5db1 to e7bb9ac Compare January 16, 2026 09:09

saintube reviewed Jan 19, 2026

View reviewed changes

pkg/koordlet/qosmanager/plugins/util/evict.go Outdated Show resolved Hide resolved

pkg/koordlet/qosmanager/plugins/cpuevict/cpu_evict.go Outdated Show resolved Hide resolved

pkg/koordlet/qosmanager/plugins/memoryevict/memory_evict.go Outdated Show resolved Hide resolved

saintube reviewed Jan 19, 2026

View reviewed changes

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch 2 times, most recently from 26851b5 to 02efad6 Compare January 20, 2026 09:18

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch 3 times, most recently from 1ea9924 to d948e31 Compare January 22, 2026 07:19

ZiMengSheng added concept/qos concept/colocation labels Jan 22, 2026

ZiMengSheng added this to the v1.8 milestone Jan 22, 2026

lijunxin559 mentioned this pull request Jan 23, 2026

[REQUEST Membership]: New membership for lijunxin559 koordinator-sh/community#16

Closed

6 tasks

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch 3 times, most recently from a4bcedd to 34bc444 Compare January 28, 2026 08:39

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch from 34bc444 to e85a299 Compare February 6, 2026 05:57

koordlet: support eviction trigger by allocatable

e2cbe83

Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch from e85a299 to 47ecbbb Compare February 6, 2026 06:11

saintube reviewed Feb 12, 2026

View reviewed changes

pkg/koordlet/qosmanager/plugins/cpuevict/cpu_evict.go Outdated Show resolved Hide resolved

koordinator-bot bot assigned saintube Feb 12, 2026

koordinator-bot bot added the lgtm label Feb 12, 2026

koordlet: support eviction trigger by allocatable

b624568

Signed-off-by: lijunxin <lijunxin.ljx@alibaba-inc.com>

lijunxin559 force-pushed the support-eviction-trigger-by-allocatable branch from 47ecbbb to b624568 Compare February 12, 2026 09:24

koordinator-bot bot removed the lgtm label Feb 12, 2026

koordinator-bot bot added the lgtm label Feb 12, 2026

AutuSnow reviewed Feb 23, 2026

View reviewed changes

Conversation

lijunxin559 commented Jan 16, 2026

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

Uh oh!

codecov bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saintube left a comment

Choose a reason for hiding this comment

Uh oh!

lijunxin559 commented Jan 20, 2026

Uh oh!

saintube commented Jan 21, 2026

Uh oh!

saintube commented Jan 21, 2026

Uh oh!

Uh oh!

saintube commented Feb 12, 2026

Uh oh!

koordinator-bot bot commented Feb 12, 2026

Uh oh!

saintube commented Feb 12, 2026

Uh oh!

AutuSnow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

AutuSnow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

AutuSnow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

AutuSnow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

AutuSnow Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

AutuSnow commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 16, 2026 •

edited

Loading