docker-proxy: ensure cgroup parent for docker is valid#281
Conversation
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 61.06% 61.12% +0.05%
==========================================
Files 103 103
Lines 9599 9613 +14
==========================================
+ Hits 5862 5876 +14
Misses 3250 3250
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
01c5f96 to
f24746f
Compare
Signed-off-by: Cheimu <xerhoneyfc@gmail.com>
f24746f to
3773eaa
Compare
|
/lgtm |
Signed-off-by: Cheimu <xerhoneyfc@gmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Cheimu xerhoneyfc@gmail.com
Ⅰ. Describe what this PR does
For Docker container runtime, and systemd cgroup driver, the cgroup parent only container pod directory. If pass it a relative directory from kubepods.slice, there will be an OCI error. So this PR:
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews