Skip to content

koord-scheduler: implement NodeNUMAResource plugin with CPUSet scheduling#289

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:support_cpuset_scheduling
Jun 28, 2022
Merged

koord-scheduler: implement NodeNUMAResource plugin with CPUSet scheduling#289
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:support_cpuset_scheduling

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Jun 22, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#96
#226

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from hormes and yihuifeng June 22, 2022 07:04
@eahydra
Copy link
Member Author

eahydra commented Jun 22, 2022

/hold

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #289 (4addeef) into main (2d23602) will increase coverage by 1.08%.
The diff coverage is 72.31%.

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   63.47%   64.56%   +1.08%     
==========================================
  Files         106      112       +6     
  Lines        9745    11022    +1277     
==========================================
+ Hits         6186     7116     +930     
- Misses       3064     3346     +282     
- Partials      495      560      +65     
Flag Coverage Δ
unittests 64.56% <72.31%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...scheduler/plugins/nodenumaresource/cpu_topology.go 30.35% <30.35%> (ø)
...heduler/plugins/nodenumaresource/node_numa_info.go 60.24% <60.24%> (ø)
pkg/scheduler/plugins/nodenumaresource/plugin.go 68.95% <68.95%> (ø)
...cheduler/plugins/nodenumaresource/plugin_helper.go 78.26% <78.26%> (ø)
...cheduler/plugins/nodenumaresource/cpu_allocator.go 82.94% <82.94%> (ø)
pkg/scheduler/plugins/nodenumaresource/cpuset.go 84.37% <84.37%> (ø)
pkg/scheduler/plugins/loadaware/load_aware.go 75.12% <0.00%> (+3.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d23602...4addeef. Read the comment docs.

@eahydra
Copy link
Member Author

eahydra commented Jun 22, 2022

I will split this pr later.

@jasonliu747
Copy link
Member

jasonliu747 commented Jun 22, 2022

I will split this pr later.

At least three, please.
image

@eahydra eahydra force-pushed the support_cpuset_scheduling branch 7 times, most recently from 4d98540 to ee911e2 Compare June 24, 2022 08:54
@eahydra eahydra marked this pull request as ready for review June 24, 2022 09:57
@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes June 24, 2022 09:57
@eahydra eahydra force-pushed the support_cpuset_scheduling branch 3 times, most recently from aa9af99 to 1dda593 Compare June 24, 2022 17:02
@eahydra
Copy link
Member Author

eahydra commented Jun 24, 2022

/hold cancel

@eahydra eahydra force-pushed the support_cpuset_scheduling branch from 1dda593 to 119b54e Compare June 27, 2022 05:44
@eahydra eahydra changed the title scheduler: support CPUSet for LSR koord-scheduler: implement NodeNUMAResource plugin with CPUSet scheduling Jun 27, 2022
@eahydra eahydra requested a review from hormes June 27, 2022 09:12
@eahydra eahydra force-pushed the support_cpuset_scheduling branch 7 times, most recently from 906230b to fa7d488 Compare June 28, 2022 03:40
@eahydra eahydra requested a review from hormes June 28, 2022 03:44
@eahydra eahydra force-pushed the support_cpuset_scheduling branch from fa7d488 to 5aab2a8 Compare June 28, 2022 05:55
…ling

This plugin extends the PreFilter/Filter/Score/Reserve/PreBind interfaces.

- Support LSE/LSR Pods to configure FullPCPUs and SpreadByPCPUs policies
  to apply for NUMA-Aware CPUSet.
- Supports configuring MostAllocated or LeastAllocated policies during
  scoring phase to select nodes that meet CPUBindPolicy requirements.

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_cpuset_scheduling branch from 5aab2a8 to 4addeef Compare June 28, 2022 06:12
@eahydra eahydra requested a review from saintube June 28, 2022 07:13
@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Jun 28, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ea82b20 into koordinator-sh:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants