Skip to content

feat: add accessing kubelet with http option for koordlet#304

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
jasonliu747:https
Jun 24, 2022
Merged

feat: add accessing kubelet with http option for koordlet#304
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
jasonliu747:https

Conversation

@jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented Jun 23, 2022

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes June 23, 2022 03:56
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #304 (ef3e6d1) into main (fd1af77) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   61.84%   61.86%   +0.01%     
==========================================
  Files         103      103              
  Lines        9614     9618       +4     
==========================================
+ Hits         5946     5950       +4     
  Misses       3170     3170              
  Partials      498      498              
Flag Coverage Δ
unittests 61.86% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_informer.go 39.25% <20.00%> (ø)
pkg/koordlet/statesinformer/config.go 100.00% <100.00%> (ø)
pkg/koordlet/statesinformer/kubelet_stub.go 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1af77...ef3e6d1. Read the comment docs.

@jasonliu747
Copy link
Member Author

jasonliu747 commented Jun 23, 2022

/cc @eahydra
Please be aware this PR will add/modify command line flag of koordlet.

@koordinator-bot koordinator-bot bot requested a review from eahydra June 23, 2022 06:22
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@eahydra
Copy link
Member

eahydra commented Jun 24, 2022

/cc @eahydra Please be aware this PR will add/modify command line flag of koordlet.

nice!

@zwzhang0107
Copy link
Contributor

/cc @eahydra Please be aware this PR will add/modify command line flag of koordlet.

looking forward

@hormes
Copy link
Member

hormes commented Jun 24, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c6bc07f into koordinator-sh:main Jun 24, 2022
@jasonliu747 jasonliu747 deleted the https branch June 24, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants