Skip to content

koord-scheduler: refactor framework extender init function#307

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:refactor_scheduler_frameworkext
Jun 24, 2022
Merged

koord-scheduler: refactor framework extender init function#307
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:refactor_scheduler_frameworkext

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Jun 23, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #307 (dbb8786) into main (74b8f03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   61.84%   61.84%           
=======================================
  Files         103      103           
  Lines        9614     9614           
=======================================
  Hits         5946     5946           
  Misses       3170     3170           
  Partials      498      498           
Flag Coverage Δ
unittests 61.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b8f03...dbb8786. Read the comment docs.

@eahydra eahydra requested review from hormes and jasonliu747 and removed request for FillZpp and yihuifeng June 23, 2022 16:57
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the refactor_scheduler_frameworkext branch from 6df9087 to dbb8786 Compare June 24, 2022 03:31
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jasonliu747
Copy link
Member

jasonliu747 commented Jun 24, 2022

Noted: Instead of importing github.com/k8stopologyawareschedwg/noderesourcetopology-api, we should use koordlet to collect and report machine topology information in the later version. For further details, please check #232.

@hormes
Copy link
Member

hormes commented Jun 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d331a10 into koordinator-sh:main Jun 24, 2022
@eahydra eahydra added this to the v0.5 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants