Skip to content

bugfix: fix noderesource-controller, reporter reconcile on node deletion#309

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-noderesource-on-node-deletion
Jun 24, 2022
Merged

bugfix: fix noderesource-controller, reporter reconcile on node deletion#309
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-noderesource-on-node-deletion

Conversation

@saintube
Copy link
Member

@saintube saintube commented Jun 24, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Fix the reconciliation of noderesource & reporter when the requested node is deleted.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Node deletion should not be reconciled by noderesource-controller.

Ⅳ. Special notes for reviews

link: how does controller-runtime invoke Reconcile()

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #309 (7344906) into main (8289720) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   61.84%   62.59%   +0.74%     
==========================================
  Files         103      103              
  Lines        9614     9616       +2     
==========================================
+ Hits         5946     6019      +73     
+ Misses       3170     3093      -77     
- Partials      498      504       +6     
Flag Coverage Δ
unittests 62.59% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/reporter/reporter.go 38.05% <100.00%> (+31.41%) ⬆️
...controller/noderesource/noderesource_controller.go 46.55% <100.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8289720...7344906. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube force-pushed the fix-noderesource-on-node-deletion branch from b159739 to 7344906 Compare June 24, 2022 08:05
@koordinator-bot koordinator-bot bot removed the lgtm label Jun 24, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 24, 2022
@hormes
Copy link
Member

hormes commented Jun 24, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4bf748b into koordinator-sh:main Jun 24, 2022
@jasonliu747 jasonliu747 added this to the v0.5 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants