bugfix: fix noderesource-controller, reporter reconcile on node deletion#309
Conversation
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 61.84% 62.59% +0.74%
==========================================
Files 103 103
Lines 9614 9616 +2
==========================================
+ Hits 5946 6019 +73
+ Misses 3170 3093 -77
- Partials 498 504 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: saintube <saintube@foxmail.com>
b159739 to
7344906
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Fix the reconciliation of noderesource & reporter when the requested node is deleted.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Node deletion should not be reconciled by noderesource-controller.
Ⅳ. Special notes for reviews
link: how does
controller-runtimeinvokeReconcile()V. Checklist
make test