feature: report cpu info to noderesoucetopology#312
Merged
hormes merged 1 commit intokoordinator-sh:mainfrom Jun 28, 2022
Merged
feature: report cpu info to noderesoucetopology#312hormes merged 1 commit intokoordinator-sh:mainfrom
hormes merged 1 commit intokoordinator-sh:mainfrom
Conversation
jasonliu747
requested changes
Jun 24, 2022
eahydra
requested changes
Jun 25, 2022
pkg/koordlet/statesinformer/states_noderesourcetopology_test.go
Outdated
Show resolved
Hide resolved
pkg/koordlet/statesinformer/states_noderesourcetopology_test.go
Outdated
Show resolved
Hide resolved
eahydra
reviewed
Jun 25, 2022
cd63426 to
ae29d79
Compare
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 63.55% 63.53% -0.02%
==========================================
Files 106 107 +1
Lines 9754 9897 +143
==========================================
+ Hits 6199 6288 +89
- Misses 3062 3101 +39
- Partials 493 508 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zwzhang0107
reviewed
Jun 27, 2022
eahydra
reviewed
Jun 27, 2022
stormgbs
reviewed
Jun 27, 2022
stormgbs
reviewed
Jun 27, 2022
stormgbs
reviewed
Jun 27, 2022
stormgbs
reviewed
Jun 27, 2022
stormgbs
reviewed
Jun 27, 2022
hormes
reviewed
Jun 27, 2022
jasonliu747
reviewed
Jun 27, 2022
7a4a247 to
2ccf7f3
Compare
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
Contributor
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fix #264
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test