Skip to content

koord-scheduler: compatible with Kubernetes v1.18 ~ v1.20#315

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:compatible_k8s
Jun 27, 2022
Merged

koord-scheduler: compatible with Kubernetes v1.18 ~ v1.20#315
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:compatible_k8s

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Jun 27, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fix #310

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #315 (b87bdc7) into main (6e097f9) will increase coverage by 0.08%.
The diff coverage is 80.43%.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   62.60%   62.69%   +0.08%     
==========================================
  Files         103      104       +1     
  Lines        9620     9666      +46     
==========================================
+ Hits         6023     6060      +37     
- Misses       3093     3099       +6     
- Partials      504      507       +3     
Flag Coverage Δ
unittests 62.69% <80.43%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/compatibledefaultpreemption/preemption.go 80.43% <80.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e097f9...b87bdc7. Read the comment docs.

@eahydra
Copy link
Member Author

eahydra commented Jun 27, 2022

/hold

@eahydra eahydra added this to the v0.5 milestone Jun 27, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra
Copy link
Member Author

eahydra commented Jun 27, 2022

/hold cancel

@eahydra eahydra requested review from jasonliu747 and saintube and removed request for FillZpp June 27, 2022 06:42
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Jun 27, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5da05b3 into koordinator-sh:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] koord-scheduler Failed to watch some object

4 participants