Skip to content

add cpuset allocator#324

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zwzhang0107:koordlet-cpuset
Jun 30, 2022
Merged

add cpuset allocator#324
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zwzhang0107:koordlet-cpuset

Conversation

@zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Jun 29, 2022

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #265

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #324 (19839b0) into main (a49ab45) will increase coverage by 0.20%.
The diff coverage is 81.61%.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   64.68%   64.89%   +0.20%     
==========================================
  Files         114      116       +2     
  Lines       11303    11436     +133     
==========================================
+ Hits         7311     7421     +110     
- Misses       3407     3428      +21     
- Partials      585      587       +2     
Flag Coverage Δ
unittests 64.89% <81.61%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/config.go 14.28% <ø> (ø)
pkg/koordlet/statesinformer/states_informer.go 43.58% <ø> (ø)
pkg/koordlet/statesinformer/register.go 72.36% <33.33%> (+0.74%) ⬆️
pkg/koordlet/runtimehooks/hooks/cpuset/cpuset.go 65.21% <65.21%> (ø)
...dlet/statesinformer/states_noderesourcetopology.go 63.51% <69.23%> (+0.55%) ⬆️
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 95.83% <95.83%> (ø)
pkg/koordlet/runtimehooks/runtimehooks.go 61.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49ab45...19839b0. Read the comment docs.

@zwzhang0107
Copy link
Contributor Author

/hold

Signed-off-by: zwzhang0107 <zuoweizhang@outlook.com>
@zwzhang0107
Copy link
Contributor Author

/hold cancel

@hormes
Copy link
Member

hormes commented Jun 30, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a6b005f into koordinator-sh:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[proposal] CPUSet injections for pod with koord QoS

2 participants