chore: remove useless feature-gates#336
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom Jul 1, 2022
Merged
chore: remove useless feature-gates#336koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 64.91% 64.89% -0.02%
==========================================
Files 116 116
Lines 11438 11438
==========================================
- Hits 7425 7423 -2
- Misses 3426 3428 +2
Partials 587 587
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jasonliu747
pushed a commit
to jasonliu747/koordinator
that referenced
this pull request
Jul 26, 2022
Signed-off-by: saintube <saintube@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Cleanup useless feature-gates
NodeMetricControl,NodeResourceControl.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test