Skip to content

chore: supply UT for pkg/util and pkg/util/system#374

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:unit-test-supplying
Jul 18, 2022
Merged

chore: supply UT for pkg/util and pkg/util/system#374
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:unit-test-supplying

Conversation

@ZiMengSheng
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from hormes and yihuifeng July 15, 2022 15:04
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #374 (99ce220) into main (d763879) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   66.28%   66.55%   +0.26%     
==========================================
  Files         116      116              
  Lines       11580    11580              
==========================================
+ Hits         7676     7707      +31     
+ Misses       3315     3283      -32     
- Partials      589      590       +1     
Flag Coverage Δ
unittests 66.55% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️
pkg/util/system/cgroup.go 66.66% <0.00%> (+6.83%) ⬆️
pkg/util/utils.go 89.33% <0.00%> (+13.33%) ⬆️
pkg/util/resource.go 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d763879...99ce220. Read the comment docs.

@jasonliu747
Copy link
Member

Hi, thanks for your contribution. Please follow the instruction below to sign off your commit.
image

And BTW, I think you could also include TestMinInt64 and TestMaxInt64 like you did in the last PR.

@ZiMengSheng ZiMengSheng force-pushed the unit-test-supplying branch from 637268b to 926a3c5 Compare July 15, 2022 15:19
@ZiMengSheng
Copy link
Member Author

okay,I will add that.

Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
@hormes
Copy link
Member

hormes commented Jul 18, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit fa0c35c into koordinator-sh:main Jul 18, 2022
@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 19, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants