Skip to content

chore: cleanup resmanager#383

Merged
hormes merged 1 commit intokoordinator-sh:mainfrom
saintube:cleanup-resmgr
Jul 20, 2022
Merged

chore: cleanup resmanager#383
hormes merged 1 commit intokoordinator-sh:mainfrom
saintube:cleanup-resmgr

Conversation

@saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

cleanup for koordlet/resmanager

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
@koordinator-bot koordinator-bot bot requested review from FillZpp and zwzhang0107 July 20, 2022 02:46
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hormes after the PR has been reviewed.
You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #383 (adb9e4c) into main (dab5a92) will increase coverage by 0.06%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   66.50%   66.56%   +0.06%     
==========================================
  Files         116      116              
  Lines       11669    11668       -1     
==========================================
+ Hits         7760     7767       +7     
+ Misses       3308     3300       -8     
  Partials      601      601              
Flag Coverage Δ
unittests 66.56% <14.28%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/feature.go 0.00% <0.00%> (ø)
pkg/koordlet/resmanager/resmanager.go 56.66% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab5a92...adb9e4c. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 20, 2022
@hormes hormes merged commit 4d9f218 into koordinator-sh:main Jul 20, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: saintube <saintube@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants