Skip to content

koordlet: introduce Accelerators feature gate for GPU related features#393

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
jasonliu747:gpu-feature-gate
Jul 25, 2022
Merged

koordlet: introduce Accelerators feature gate for GPU related features#393
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
jasonliu747:gpu-feature-gate

Conversation

@jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and stormgbs July 22, 2022 06:45
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #393 (fbff312) into main (5b320c0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   66.36%   66.33%   -0.04%     
==========================================
  Files         118      118              
  Lines       12063    12064       +1     
==========================================
- Hits         8006     8003       -3     
- Misses       3434     3437       +3     
- Partials      623      624       +1     
Flag Coverage Δ
unittests 66.33% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metricsadvisor/collector.go 9.53% <ø> (+0.05%) ⬆️
pkg/koordlet/metricsadvisor/collector_gpu.go 34.61% <100.00%> (-1.70%) ⬇️
pkg/util/system/common_linux.go 53.84% <0.00%> (-3.85%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b320c0...fbff312. Read the comment docs.

@jasonliu747 jasonliu747 requested review from LambdaHJ, eahydra, hormes, saintube and zwzhang0107 and removed request for FillZpp and stormgbs July 24, 2022 06:10
@jasonliu747 jasonliu747 force-pushed the gpu-feature-gate branch 3 times, most recently from c58d7bb to 44ae5ca Compare July 25, 2022 03:41
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@LambdaHJ
Copy link
Contributor

/lgtm

Copy link
Contributor

@LambdaHJ LambdaHJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, LambdaHJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 779ac80 into koordinator-sh:main Jul 25, 2022
@jasonliu747 jasonliu747 deleted the gpu-feature-gate branch July 26, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants