Skip to content

api: update PodMigrationJob and Reservation CRD#399

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:update_podmigrationjob_reservation_api
Jul 25, 2022
Merged

api: update PodMigrationJob and Reservation CRD#399
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
eahydra:update_podmigrationjob_reservation_api

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Jul 22, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #399 (9d6eac5) into main (0faf65e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   66.33%   66.34%   +0.01%     
==========================================
  Files         118      118              
  Lines       12059    12059              
==========================================
+ Hits         7999     8001       +2     
+ Misses       3436     3434       -2     
  Partials      624      624              
Flag Coverage Δ
unittests 66.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0faf65e...9d6eac5. Read the comment docs.

@eahydra eahydra force-pushed the update_podmigrationjob_reservation_api branch from a0e6ddb to 714888d Compare July 25, 2022 08:37
@eahydra eahydra marked this pull request as ready for review July 25, 2022 08:38
@eahydra eahydra requested a review from saintube July 25, 2022 08:38
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the update_podmigrationjob_reservation_api branch from 714888d to 9d6eac5 Compare July 25, 2022 08:46
@saintube
Copy link
Member

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 47e7189 into koordinator-sh:main Jul 25, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants