Skip to content

api: add Gang api#409

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
buptcozy:gang_consts
Aug 2, 2022
Merged

api: add Gang api#409
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
buptcozy:gang_consts

Conversation

@Wenshiqi222
Copy link
Contributor

Ⅰ. Describe what this PR does

add some consts for gang scheduling

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes July 26, 2022 10:38
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #409 (f6986e8) into main (fbf4d97) will increase coverage by 1.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   66.23%   67.90%   +1.67%     
==========================================
  Files         120      137      +17     
  Lines       12157    14915    +2758     
==========================================
+ Hits         8052    10128    +2076     
- Misses       3477     4036     +559     
- Partials      628      751     +123     
Flag Coverage Δ
unittests 67.90% <ø> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️
pkg/descheduler/node/node.go 86.04% <0.00%> (ø)
pkg/descheduler/evictions/evictions.go 90.90% <0.00%> (ø)
pkg/scheduler/plugins/reservation/rpod.go 100.00% <0.00%> (ø)
pkg/descheduler/utils/priority.go 100.00% <0.00%> (ø)
pkg/scheduler/plugins/reservation/utils.go 71.01% <0.00%> (ø)
...kg/descheduler/controllers/migration/controller.go 66.53% <0.00%> (ø)
...cheduler/plugins/reservation/garbage_collection.go 89.09% <0.00%> (ø)
pkg/descheduler/utils/predicates.go 80.57% <0.00%> (ø)
pkg/descheduler/controllers/migration/util/util.go 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf4d97...f6986e8. Read the comment docs.

@Wenshiqi222 Wenshiqi222 changed the title add gang Consts api: add Gang api Aug 1, 2022
@Wenshiqi222 Wenshiqi222 force-pushed the gang_consts branch 5 times, most recently from 15ab387 to a0df327 Compare August 1, 2022 13:14
Signed-off-by: wenshiqi <wen470366661@163.com>
@eahydra
Copy link
Member

eahydra commented Aug 2, 2022

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Aug 2, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit bb3065a into koordinator-sh:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants