Skip to content

koord-descheduler: implement descheduling configuration#422

Merged
eahydra merged 1 commit intokoordinator-sh:mainfrom
eahydra:implement_descheduler_config
Aug 1, 2022
Merged

koord-descheduler: implement descheduling configuration#422
eahydra merged 1 commit intokoordinator-sh:mainfrom
eahydra:implement_descheduler_config

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Aug 1, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v0.6 milestone Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #422 (cb46e4d) into main (fbf4d97) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   66.23%   66.21%   -0.02%     
==========================================
  Files         120      120              
  Lines       12157    12157              
==========================================
- Hits         8052     8050       -2     
- Misses       3477     3479       +2     
  Partials      628      628              
Flag Coverage Δ
unittests 66.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf4d97...cb46e4d. Read the comment docs.

@hormes
Copy link
Member

hormes commented Aug 1, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saintube
Copy link
Member

saintube commented Aug 1, 2022

/lgtm

@eahydra eahydra merged commit 78afa0a into koordinator-sh:main Aug 1, 2022
@eahydra
Copy link
Member Author

eahydra commented Aug 1, 2022

part of implementation #196 #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants