fix reservation on pod patch failed#428
Merged
hormes merged 1 commit intokoordinator-sh:mainfrom Aug 2, 2022
Merged
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
9d31e55 to
fb92b1c
Compare
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 67.79% 67.75% -0.04%
==========================================
Files 134 134
Lines 14297 14313 +16
==========================================
+ Hits 9692 9698 +6
- Misses 3891 3900 +9
- Partials 714 715 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Fix reservation status updating when the plugin failed to patch pod with reservation info.
Ⅱ. Does this pull request fix one issue?
fixes #429
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test