Skip to content

fix reservation on pod patch failed#428

Merged
hormes merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-reservation
Aug 2, 2022
Merged

fix reservation on pod patch failed#428
hormes merged 1 commit intokoordinator-sh:mainfrom
saintube:fix-reservation

Conversation

@saintube
Copy link
Member

@saintube saintube commented Aug 2, 2022

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Fix reservation status updating when the plugin failed to patch pod with reservation info.

Ⅱ. Does this pull request fix one issue?

fixes #429

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and hormes August 2, 2022 02:29
Signed-off-by: saintube <saintube@foxmail.com>
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #428 (fb92b1c) into main (1cf37d0) will decrease coverage by 0.03%.
The diff coverage is 68.29%.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   67.79%   67.75%   -0.04%     
==========================================
  Files         134      134              
  Lines       14297    14313      +16     
==========================================
+ Hits         9692     9698       +6     
- Misses       3891     3900       +9     
- Partials      714      715       +1     
Flag Coverage Δ
unittests 67.75% <68.29%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/eventhandlers/reservation_handler.go 50.00% <25.00%> (ø)
pkg/scheduler/plugins/reservation/utils.go 71.01% <62.50%> (-1.50%) ⬇️
...cheduler/plugins/reservation/garbage_collection.go 89.09% <83.33%> (+0.41%) ⬆️
pkg/scheduler/plugins/reservation/rcache.go 62.23% <100.00%> (ø)
pkg/scheduler/plugins/reservation/rpod.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf37d0...fb92b1c. Read the comment docs.

@hormes
Copy link
Member

hormes commented Aug 2, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes hormes merged commit 9e8fc01 into koordinator-sh:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Reservation status got duplicated owners when scheduler is not permitted to patch pod.

2 participants