Skip to content

koord-descheduler: release Reservation when PodMigrationJob completes or is deleted#438

Merged
hormes merged 1 commit intokoordinator-sh:mainfrom
eahydra:descheduler_release_reservation
Aug 4, 2022
Merged

koord-descheduler: release Reservation when PodMigrationJob completes or is deleted#438
hormes merged 1 commit intokoordinator-sh:mainfrom
eahydra:descheduler_release_reservation

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Aug 4, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from hormes and yihuifeng August 4, 2022 03:37
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hormes after the PR has been reviewed.
You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eahydra eahydra removed the request for review from yihuifeng August 4, 2022 03:38
@eahydra eahydra force-pushed the descheduler_release_reservation branch from 0c44a29 to 526c55e Compare August 4, 2022 03:42
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #438 (17cdb6d) into main (0b3ee58) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   67.89%   67.91%   +0.01%     
==========================================
  Files         137      137              
  Lines       14989    14999      +10     
==========================================
+ Hits        10177    10186       +9     
+ Misses       4051     4050       -1     
- Partials      761      763       +2     
Flag Coverage Δ
unittests 67.91% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/descheduler/controllers/migration/controller.go 65.27% <0.00%> (-1.27%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 81.05% <0.00%> (+9.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra changed the title koord-descheduler: release Reservation when PodMigrationJob completed… koord-descheduler: release Reservation when PodMigrationJob completes or is deleted Aug 4, 2022
… or is deleted

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the descheduler_release_reservation branch from 526c55e to 17cdb6d Compare August 4, 2022 04:55
@hormes hormes merged commit 3ed131c into koordinator-sh:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants