koord-scheduler: improve reservation validation

[saintube]

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Separate basic reservation validation into CRD validation and plugin validation, remove object enqueue validation

Ⅱ. Does this pull request fix one issue?

fixes #439

Ⅲ. Describe how to verify it

1. use kubectl create to create an invalid reservation (e.g. with nil template, nil owner, empty Owner)
2. check the validation message if the create failed
3. check the reservation status if the create succeeded

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[codecov]

Codecov Report

Merging #442 (8455171) into main (bed2191) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   67.95%   67.90%   -0.05%     
==========================================
  Files         137      137              
  Lines       14989    14982       -7     
==========================================
- Hits        10186    10174      -12     
- Misses       4042     4047       +5     
  Partials      761      761              

Flag	Coverage Δ
unittests	67.90% <75.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/scheduler/eventhandlers/reservation_handler.go	50.00% <50.00%> (-2.44%)	⬇️
pkg/scheduler/plugins/reservation/rpod.go	93.33% <66.66%> (-6.67%)	⬇️
...cheduler/plugins/reservation/garbage_collection.go	89.18% <100.00%> (+0.09%)	⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go	78.94% <0.00%> (-2.11%)	⬇️
...kg/descheduler/controllers/migration/controller.go	65.27% <0.00%> (-1.27%)	⬇️
pkg/scheduler/plugins/reservation/utils.go	72.92% <0.00%> (+1.91%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[eahydra]

/lgtm

[hormes]

/approve

[koordinator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hormes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment