Skip to content

bugfix: avoid pod terminating in docker#445

Merged
hormes merged 1 commit intokoordinator-sh:mainfrom
ZYecho:fix-terminating
Aug 5, 2022
Merged

bugfix: avoid pod terminating in docker#445
hormes merged 1 commit intokoordinator-sh:mainfrom
ZYecho:fix-terminating

Conversation

@ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Aug 5, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #445 (6955f86) into main (f133061) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   67.92%   67.93%           
=======================================
  Files         137      137           
  Lines       14982    14980    -2     
=======================================
  Hits        10176    10176           
+ Misses       4045     4044    -1     
+ Partials      761      760    -1     
Flag Coverage Δ
unittests 67.93% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/server.go 66.66% <80.00%> (+2.60%) ⬆️
pkg/runtimeproxy/server/docker/handler.go 38.03% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (-2.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@cheimu
Copy link
Member

cheimu commented Aug 5, 2022

/lgtm

@cheimu
Copy link
Member

cheimu commented Aug 5, 2022

Note: this pr is very important, since current version, v0.6, makes kubelet fail to terminate pods under some circumstance.

@hormes
Copy link
Member

hormes commented Aug 5, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes hormes merged commit 9626a21 into koordinator-sh:main Aug 5, 2022
hormes pushed a commit that referenced this pull request Aug 5, 2022
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants