Skip to content

koord-scheduler: abstract GetPodQoSClass#471

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:abstracting_GetPodQoSClass
Aug 11, 2022
Merged

koord-scheduler: abstract GetPodQoSClass#471
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
ZiMengSheng:abstracting_GetPodQoSClass

Conversation

@ZiMengSheng
Copy link
Member

@ZiMengSheng ZiMengSheng commented Aug 11, 2022

Ⅰ. Describe what this PR does

This PR abstract GetPodQoSClass in NodeNUMAResource plugin for compatibility with internal protocols and implementations

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu <zmsjianyu@gmail.com>
@ZiMengSheng ZiMengSheng force-pushed the abstracting_GetPodQoSClass branch from 6f8f343 to af833cf Compare August 11, 2022 07:55
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #471 (af833cf) into main (a50bbb4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files         145      145           
  Lines       15275    15275           
=======================================
  Hits        10266    10266           
  Misses       4238     4238           
  Partials      771      771           
Flag Coverage Δ
unittests 67.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/nodenumaresource/plugin.go 70.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2d73f57 into koordinator-sh:main Aug 11, 2022
@ZiMengSheng ZiMengSheng deleted the abstracting_GetPodQoSClass branch January 13, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants