Skip to content

add extended resource schedule plugin for compatibility#472

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zwzhang0107:extended-res-scheduler
Aug 11, 2022
Merged

add extended resource schedule plugin for compatibility#472
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
zwzhang0107:extended-res-scheduler

Conversation

@zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Aug 11, 2022

Signed-off-by: 佑祎 zzw261520@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#83

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #472 (ab70488) into main (bdd719b) will increase coverage by 0.22%.
The diff coverage is 96.33%.

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   67.17%   67.40%   +0.22%     
==========================================
  Files         145      146       +1     
  Lines       15261    15384     +123     
==========================================
+ Hits        10251    10369     +118     
- Misses       4241     4244       +3     
- Partials      769      771       +2     
Flag Coverage Δ
unittests 67.40% <96.33%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scheduler/plugins/batchresource/batch_resource.go 96.33% <96.33%> (ø)
pkg/scheduler/plugins/nodenumaresource/plugin.go 70.11% <0.00%> (-1.18%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 78.94% <0.00%> (+7.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@koordinator-bot koordinator-bot bot added size/L and removed size/XL labels Aug 11, 2022
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Aug 11, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a1b1dcb into koordinator-sh:main Aug 11, 2022
@jasonliu747 jasonliu747 linked an issue Aug 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] allow extended resources to be over-committed

3 participants