Skip to content

fix metric-expire-seconds usage#495

Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
huiwq1990:bugfix-usage
Aug 17, 2022
Merged

fix metric-expire-seconds usage#495
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom
huiwq1990:bugfix-usage

Conversation

@huiwq1990
Copy link
Contributor

Signed-off-by: huiwq1990 huiwq1990@163.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: huiwq1990 <huiwq1990@163.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #495 (fc8f5b8) into main (8d53402) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   68.07%   68.05%   -0.03%     
==========================================
  Files         152      152              
  Lines       16343    16343              
==========================================
- Hits        11126    11122       -4     
- Misses       4389     4394       +5     
+ Partials      828      827       -1     
Flag Coverage Δ
unittests 68.05% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metriccache/config.go 100.00% <100.00%> (ø)
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e6abfb3 into koordinator-sh:main Aug 17, 2022
@huiwq1990 huiwq1990 deleted the bugfix-usage branch August 20, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants