Skip to content

koord-descheduler: fix incorrect handling of Reservation's status#500

Merged
hormes merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_descheduler_migrate
Aug 18, 2022
Merged

koord-descheduler: fix incorrect handling of Reservation's status#500
hormes merged 1 commit intokoordinator-sh:mainfrom
eahydra:fix_descheduler_migrate

Conversation

@eahydra
Copy link
Member

@eahydra eahydra commented Aug 17, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra requested a review from hormes August 17, 2022 14:07
@koordinator-bot koordinator-bot bot requested review from FillZpp and yihuifeng August 17, 2022 14:07
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yihuifeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @yihuifeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #500 (be606ef) into main (e6abfb3) will decrease coverage by 0.00%.
The diff coverage is 65.11%.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   68.07%   68.07%   -0.01%     
==========================================
  Files         152      152              
  Lines       16343    16372      +29     
==========================================
+ Hits        11126    11145      +19     
- Misses       4389     4397       +8     
- Partials      828      830       +2     
Flag Coverage Δ
unittests 68.07% <65.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/descheduler/controllers/migration/controller.go 65.78% <65.11%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eahydra eahydra requested a review from jasonliu747 August 17, 2022 15:58
@hormes hormes merged commit 1cd52c4 into koordinator-sh:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants