koord-scheduler: fix succeeded reservation GC and unschedulable retry

[saintube]

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

1. Fix succeeded reservations' expiration: Succeeded reservations will not become Failed, and they will get cleaned up according to their succeeding timestamp.
2. Fix unschedulable reservations' retry: Once a reservation is marked as unschedulable, it will be put into the unschedulable queue and retry in later scheduling cycles.

Ⅱ. Does this pull request fix one issue?

fixes #499

Ⅲ. Describe how to verify it

For the Fix 1.

1. submit a reservation whose allocateOnce=true and ttl is small, then make it get Succeeded
2. check if the reservation would not become Failed

For the Fix 2.

1. submit a reservation that should get unschedulable for some reasons (e.g. request too many resources)
2. check if the scheduled condition timestamp in its status changes by the time

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[koordinator-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yihuifeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @yihuifeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #501 (22d0b95) into main (e6abfb3) will decrease coverage by 0.02%.
The diff coverage is 62.03%.

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   68.07%   68.05%   -0.03%     
==========================================
  Files         152      152              
  Lines       16343    16414      +71     
==========================================
+ Hits        11126    11170      +44     
- Misses       4389     4414      +25     
- Partials      828      830       +2     

Flag	Coverage Δ
unittests	68.05% <62.03%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/scheduler/eventhandlers/internal_handler.go	66.66% <0.00%> (-9.20%)	⬇️
pkg/scheduler/eventhandlers/reservation_handler.go	48.85% <42.85%> (-0.93%)	⬇️
pkg/scheduler/plugins/reservation/utils.go	76.11% <63.63%> (+1.53%)	⬆️
pkg/scheduler/plugins/reservation/plugin.go	76.90% <90.00%> (+0.05%)	⬆️
...cheduler/plugins/reservation/garbage_collection.go	82.14% <100.00%> (ø)
pkg/scheduler/plugins/reservation/rcache.go	83.25% <100.00%> (ø)
...kg/descheduler/controllers/migration/controller.go	65.78% <0.00%> (-0.02%)	⬇️
pkg/util/httputil/reverseproxy.go	84.84% <0.00%> (+0.53%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.