koord-manager: record configmap and pod qos unmarshal failed events#518
Merged
koordinator-bot[bot] merged 4 commits intokoordinator-sh:mainfrom Aug 25, 2022
Merged
Conversation
…informer cache Signed-off-by: songtao98 <songtao2603060@gmail.com>
Signed-off-by: songtao98 <songtao2603060@gmail.com>
jasonliu747
requested changes
Aug 24, 2022
Member
jasonliu747
left a comment
There was a problem hiding this comment.
建议 commit 之前在本地先执行 make lint fast-test
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 67.96% 67.96%
=======================================
Files 155 155
Lines 16526 16576 +50
=======================================
+ Hits 11232 11266 +34
- Misses 4460 4472 +12
- Partials 834 838 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: songtao98 <songtao2603060@gmail.com>
Member
Member
|
/lgtm |
Member
|
/lgtm |
jasonliu747
approved these changes
Aug 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…informer cache
Signed-off-by: songtao98 songtao2603060@gmail.com
Ⅰ. Describe what this PR does
Basically add EventRecorder to each slo-controllers and use Eventf() to record unmarshal failed events when errors occur
Ⅱ. Does this pull request fix one issue?
fixes #482
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test